Skip to content

format:base64 doesn't exist -> format:byte #3182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 4, 2023
Merged

format:base64 doesn't exist -> format:byte #3182

merged 2 commits into from
Mar 4, 2023

Conversation

ralfhandl
Copy link
Contributor

@ralfhandl ralfhandl commented Mar 2, 2023

@handrews
Copy link
Member

handrews commented Mar 2, 2023

Great - thanks! For some reason GitHub won't let me add comments on the lines in question, but while you're doing this could you delete the two blank (type but no format) lines in the Data Formats table? There's one between double and byte and another between binary and date.

@karenetheridge
Copy link
Member

karenetheridge commented Mar 2, 2023

'format: byte` doesn't exist either though... [edit: oh, I see, it does in 3.0.x, but not 3.1)

@handrews
Copy link
Member

handrews commented Mar 2, 2023

@karenetheridge it's defined in §4.4 Data Types.

@ralfhandl
Copy link
Contributor Author

could you delete the two blank (type but no format) lines in the Data Formats table?

@handrews Done

Copy link
Member

@handrews handrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This (blank lines and byte vs base64) has been bugging me for years 🥳

Copy link
Member

@MikeRalphson MikeRalphson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@darrelmiller
Copy link
Member

Thank you all! Merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants